feat(metrics): add generation_tokens_total and prompt_tokens_total metrics #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mayabar
requested changes
Dec 7, 2025
googs1025
force-pushed
the
add/counter
branch
2 times, most recently
from
100bb9f to
b49b40b
Compare
mayabar
requested changes
Dec 8, 2025
Collaborator
mayabar
left a comment
mayabar
left a comment
There was a problem hiding this comment.
Added some comments regarding buckets limits
googs1025
force-pushed
the
add/counter
branch
3 times, most recently
from
4ee6b72 to
41b7839
Compare
mayabar
requested changes
Dec 9, 2025
Collaborator
mayabar
left a comment
mayabar
left a comment
There was a problem hiding this comment.
some additional comments
googs1025
force-pushed
the
add/counter
branch
from
41b7839 to
b27a5bf
Compare
…trics Signed-off-by: CYJiang <googs1025@gmail.com>
googs1025
force-pushed
the
add/counter
branch
from
b27a5bf to
f9ffada
Compare
Contributor
Author
|
@mayabar |
mayabar
approved these changes
Dec 17, 2025
Collaborator
|
/lgtm |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.